Assign image tag based on the pulsar wheel version #183
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can help find a docker image if its tag is set appropriately, e.g., using the version of pulsar wheel used for creating the image.
On my mac I am not able to leverage
BASH_REMATCH[1]
to extract version number from the wheel filename, since it seems macOS has a different function that overrides the value of this variable: https://stackoverflow.com/a/40457982Creating draft PR, in case anyone interested and know a workaround.
Alternatively, we might be able to use a method similar to the following:
pulsar/setup.py
Lines 46 to 50 in ddf2fde