Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new ChIP-Seq WF that handles replicates and controls #581

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

wm75
Copy link
Contributor

@wm75 wm75 commented Oct 24, 2024

Not quite ready yet, but time to bring online.

@lldelisle another variation of the theme :-)
Essentially, an automated version of the steps in https://training.galaxyproject.org/training-material/topics/epigenetics/tutorials/formation_of_super-structures_on_xi/tutorial.html#formation-of-the-super-structures-on-the-inactive-x

This comment was marked as outdated.

@lldelisle
Copy link
Contributor

Hi,
Looks great indeed and too complex to be merged with the existing one.

@wm75
Copy link
Contributor Author

wm75 commented Oct 25, 2024

Hi, Looks great indeed and too complex to be merged with the existing one.

That's what I thought, too, even though I borrowed a lot from your WFs (like the entire backbone of the analysis, and the averaging across replicates), so if you want to, I can add you as a WF author.

You may want to have a look at using fastp instead of cutadapt, which makes it possible to have optional adapter sequences and the updated samtools view step I'm using. Those could be integrated easily into your WF I guess.

@lldelisle
Copy link
Contributor

Yes, I also think it would be beneficial to use fastp instead of cutadapt in all my workflows.

This comment was marked as outdated.

@pavanvidem
Copy link
Member

@wm75 it seems there is no 'Calculate numeric parameter value' tool on .org.

@wm75
Copy link
Contributor Author

wm75 commented Oct 25, 2024

Funny, it's an iuc tool: https://github.com/galaxyproject/tools-iuc/tree/main/tools/calculate_numeric_param
Probably just oversight @mvdbeek?

@bgruening
Copy link
Member

Please add it here: https://github.com/galaxyproject/usegalaxy-tools

"owner": "bgruening",
"tool_shed": "toolshed.g2.bx.psu.edu"
},
"tool_state": "{\"advancedOpt\": {\"showAdvancedOpt\": \"yes\", \"__current_case__\": 1, \"binSize\": \"50\", \"sortRegions\": \"keep\", \"sortUsing\": \"mean\", \"averageTypeBins\": \"mean\", \"missingDataAsZero\": true, \"skipZeros\": true, \"minThreshold\": null, \"maxThreshold\": null, \"scale\": null, \"metagene\": false, \"transcriptID\": \"transcript\", \"exonID\": \"exon\", \"transcript_id_designator\": \"transcript_id\", \"blackListFileName\": {\"__class__\": \"RuntimeValue\"}}, \"custom_sample_labels_conditional\": {\"custom_labels_select\": \"No\", \"__current_case__\": 0}, \"mode\": {\"mode_select\": \"reference-point\", \"__current_case__\": 1, \"referencePoint\": \"center\", \"nanAfterEnd\": false, \"beforeRegionStartLength\": \"3000\", \"afterRegionStartLength\": \"3000\"}, \"multibigwig_conditional\": {\"orderMatters\": \"No\", \"__current_case__\": 0, \"bigwigfiles\": {\"__class__\": \"ConnectedValue\"}}, \"output\": {\"showOutputSettings\": \"no\", \"__current_case__\": 0}, \"regionsFiles\": [{\"__index__\": 0, \"regionsFile\": {\"__class__\": \"ConnectedValue\"}}], \"__page__\": null, \"__rerun_remap_job_id__\": null}",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the beforeRegionStartLength and the afterRegionStartLength here should not be hard-coded.
Initially I thought I could come up with a way to estimate them from the MACS2 peak region widths, but maybe we should just turn them into a WF param for now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we start with the hardcoded region length for tomorrow ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, please 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants