Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qiime2: remove spaces from names in dockstore.yml #419

Merged
merged 5 commits into from
May 27, 2024

Conversation

bernt-matthias
Copy link
Contributor

and shorten

@lldelisle
Copy link
Contributor

Can you add the CHANGELOG.md, please?
@mvdbeek Do this need a bump version? I would say yes.

@bernt-matthias
Copy link
Contributor Author

For bumping the version I just punp it in .workflowhub.yml?

@mvdbeek
Copy link
Member

mvdbeek commented May 23, 2024

Yeah, since we did create a deployment and released a version.

@lldelisle
Copy link
Contributor

For bumping the version I just punp it in .workflowhub.yml?

No you need to bump the CHANGELOG.md and each workflow change the release:""

This comment was marked as outdated.

@lldelisle
Copy link
Contributor

I love this automation with workflow report...

@bernt-matthias
Copy link
Contributor Author

I love this automation with workflow report...

Only problem is that this is not the report for the latest version .. I think .. #420

But the test might still be wrong. Lets see :)

@lldelisle
Copy link
Contributor

No, it was the report of the first commit. It does not show the report if the tests pass.

@lldelisle
Copy link
Contributor

Should I merge?

@bernt-matthias
Copy link
Contributor Author

Should I merge?

Yes, please.

@mvdbeek mvdbeek merged commit f646742 into galaxyproject:main May 27, 2024
7 checks passed
@bernt-matthias bernt-matthias deleted the topic/qiime2-names branch May 29, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants