Fix tests #317
Draft
Fix tests #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a bit scary how many tests were malformed, no? |
|
Yes, confirming that we really needed to do this. It's too easy to get it wrong without linting, schema and very minimal docs. |
|
Thanks for doing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some more cosmetic fixes (
that: "has_text"->has_text), but also fixes a lot of untested broken things here.Mostly a WIP to show the impact of galaxyproject/galaxy#17128.
The list of asserts needs to be added to galaxy-tool-util for tests to pass.