Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GalaxyWorkflow: improve parsing speed & codegen #108

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

mr-c
Copy link
Contributor

@mr-c mr-c commented Dec 2, 2024

@mvdbeek mvdbeek force-pushed the codegen_class_matching branch from 842a8ec to 1e7a112 Compare December 2, 2024 16:37
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 41.03%. Comparing base (53abe0b) to head (1e7a112).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
typescript/src/GalaxyWorkflow.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #108      +/-   ##
==========================================
+ Coverage   40.85%   41.03%   +0.17%     
==========================================
  Files          50       51       +1     
  Lines        1968     1974       +6     
  Branches      441      441              
==========================================
+ Hits          804      810       +6     
  Misses       1047     1047              
  Partials      117      117              
Flag Coverage Δ
unittests 41.03% <87.50%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mr-c mr-c marked this pull request as ready for review December 2, 2024 17:05
@mvdbeek mvdbeek merged commit 621e3f8 into galaxyproject:main Dec 2, 2024
10 checks passed
@mr-c mr-c deleted the codegen_class_matching branch December 2, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants