Split script into 2 commands: 1 to extract, 1 to filter tools #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bebatut
force-pushed
the
split_commands
branch
from
64f584b to
f559959
Compare
bebatut
force-pushed
the
split_commands
branch
from
f559959 to
b806367
Compare
nsoranzo
reviewed
Oct 31, 2023
nsoranzo
reviewed
Oct 31, 2023
nsoranzo
reviewed
Oct 31, 2023
nsoranzo
reviewed
Oct 31, 2023
Co-authored-by: Nicola Soranzo <[email protected]>
nsoranzo
reviewed
Oct 31, 2023
Co-authored-by: Nicola Soranzo <[email protected]>
Co-authored-by: Nicola Soranzo <[email protected]>
nsoranzo
reviewed
Oct 31, 2023
Co-authored-by: Nicola Soranzo <[email protected]>
nsoranzo
reviewed
Oct 31, 2023
Also: - Use `.extend()` instead of `+=` (slightly faster) - Write error messages to `sys.stderr`
nsoranzo
approved these changes
Nov 1, 2023
|
Worked for my toy set, also with duplicates, running for all repos just to be sure, then merge |
neoformit
pushed a commit
to nomadscientist/galaxy_codex
that referenced
this pull request
Jul 28, 2024
Split script into 2 commands: 1 to extract, 1 to filter tools Tested locally, got: 1295 Tool "Suits" with 16 duplicates which accounts to 2915 tool ids. Thank you @bebatut !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am still testing locally the script