Simplified Workflow Run Form #9151

jmchilton · 2019-12-19T21:18:50Z

Builds on refactoring the workflow run form landing and orchestration into Vue (#9147).

Implements #9111 - part of https://github.com/orgs/galaxyproject/projects/47 and outlined in http://bit.ly/simplified-workflow-ui.

What is in the PR:

Add new Galaxy configuration option - simplified_workflow_run_ui set to off by default.
If instead the admin has set this parameter to prefer, on the workflow run page scan the workflow run request and if three conditions are met show a simplified tool form. These conditions are:
- No workflow "resource parameters" - pretty niche, not documented, I don't think anyone outside of Canada is using them and even them I'm not sure if they ever got to production.
- No "open" tools (i.e. tools with disconnected runtime inputs).
- No "replacement parameters" defined outside PJAs. I'm calling #{} inside PJA and ${} inside tool steps both "replacement parameters" because the user populates them the same way in the GUI. The API only handles them inside the context of the PJA - it seems the GUI is responsible for replacing them at runtime in the traditional form.
The simplified workflow form:
- Drops tool and subworkflow steps from rendering all together and instead just renders the inputs. These are not rendered as separate "steps" or forms - but as just different inputs the same clean, simple form (more the like tool GUI). Labels (or step indexes as a fallback) are used at the input name, step annotations are used as the input help text.
- Simplify the workflow request made by the client - send only replacement parameters and inputs - do not serialize tool state for each module. I think this makes what we are tracking more structured and should be more performant as well. Prevents storing HDA IDs in unstructured JSON blobs in the database as well.
- Drops history target option to simplify the UI - simplified_workflow_run_ui_target_history can be set to either 'current' (default) or 'new' to adjust this parameter Galaxy-wide for the simplified form.
- Drops job caching option to simplify the UI - simplified_workflow_run_ui_job_cache can be set to 'off' (default) or 'on' to change this parameter Galaxy-wide for the simplified form.
- Drops resource parameters - we've already verified there are none for simplified workflows.

What is in the PR:

Screenshots

Original Form:

Simplified Form:

Clicking to open advanced form from simplified one:

nsoranzo · 2019-12-20T03:21:57Z

The cleanliness and simplicity of the UI is amazing, thanks @jmchilton !
@TKlingstrom will love it!

client/galaxy/scripts/components/WaitButton.vue

client/galaxy/scripts/components/Workflow/Run/WorkflowRun.vue

Based on PR review comments ( galaxyproject#9151 (comment) ).

bgruening · 2020-08-09T10:32:08Z

Would it be possible to show the simplified form even when simplified_workflow_run_ui = off but some GET parameter is sent? I think this would be nice for integration from Dockstore or workflowhub.eu.

dannon · 2020-08-11T00:29:37Z

What's the argument for putting this behind a default-off configuration option? From what the end-user sees, it's a very simple 'just don't render all the steps if I don't have to touch them', with a toggle to go to the full mode. And there are no migration considerations for an admin, right?

jmchilton · 2020-08-11T01:49:39Z

@dannon

Just me being conservative (and before my work today this not all the options on the screen worked - batch parameters were not working). At worst giving people a release to test it out and form opinions. I'm happy to make this the default I think though. Arguments against it might be more clicks to get to get to certain options and a jarring user experience when best practice workflows render the new way and other workflows render the old way.

@bgruening

It can be overridden now with simplified_workflow_run_ui=prefer in the query string.

dannon · 2020-08-11T01:52:37Z

@jmchilton Well, it would definitely be best if it worked, but yeah -- I think this becoming the default with a simple toggle (could even set a user preference for this very easily, to allow individuals to prefer simple or advanced) to show the whole form is totally fine.

guerler · 2020-08-11T12:44:37Z

This is great, thank you so much for simplifying the execution form. While looking into it I noticed that the lazy loading for steps seems to be impeded, maybe we can fix this here too. ref #10034

client/galaxy/scripts/components/Workflow/Run/WorkflowRun.vue

bgruening

Awesome! Thanks John!

dannon · 2020-08-13T14:38:29Z

lib/galaxy/webapps/galaxy/config_schema.yml

+          future 'force' may be added an option for Galaskio-style servers that should
+          only render simplified workflows.
+
+      simplified_workflow_run_ui_target_history:


This and the setting below really feel like they should be user preferences, not galaxy-wide configuration settings for the sake of simplifying a page. For more context, this notion is probably stemming from my work separating the client from the server, but this more tightly couples the displayed interface with the server and its configuration.

This project stemmed from a desire to present a completely different, simplified UI around workflows - including one that doesn't even need to present the concept of a history to users. If you wanted to deploy such an app you really wouldn't want to make this a user setting.

I'm all for decoupling - the corresponding attributes on Vue components do have defaults. They should work stand-alone in other scenarios. So they are decoupled properly in my mind. Just because we don't want to force the developer using the components to define these doesn't mean the admins shouldn't be allowed to pick defaults. Likewise, just because it would likely be good to allow user preferences in the abstract for more typical uses doesn't mean we shouldn't allow admins to be able to control how the app is configured as a default.

Having one part of the UI depend on Galaxy's concept of a user preference tab and the backend for storing and fetching those - is in fact more coupling to my mind than this. Again, the components would work without those so it seems like a fine sort of optional coupling. We have independent ways to configure these things and the component internals don't depend on how those are being configured - that would seem to be the goal to me.

Anyway, while I agree with some of this, adding the user preferences seems like outside the scope of the initial implementation. If you insist on my adding setting I will consider it to get this done, but even in that scenario I still think the defaults should be configurable by the deployer. Though I'm totally open to there being a different way for the deployer to configure the client than Galaxy's YAML.

If you insist

@jmchilton I really wasn't insisting on anything, sorry if you thought as much.

I think this component should be seen as a simple, togglable level of detail view rather than a different, server-set preference. In my mind the second pass, the actual workflow-centric interface addition, that's what would add these extra properties (however they end up) and pass them to this view. This is nice progress as a straightforward level of detail toggle on the existing workflow interface. That's what I was trying to get at above, with the configuration defaults -- it doesn't serve anyone to force one view over the other with just this piece, I don't think, and I suppose a user could just flip the interface one way or another if they wanted anyway by swapping a bit of client-side data.

Anyway, for now, it's fair enough that until we have a way to configure more (and default) client(s), that this can live in the core galaxy configuration. If you want this configurable at this point, then it's fine.

client/src/components/Workflow/Run/WorkflowRunFormSimple.vue

jmchilton · 2020-08-13T18:04:45Z

This is ancient code at this point 😂 - I’ll clean up the jquery and underscore today - thanks for the review.

Builds on refactoring the workflow run form landing and orchestration into Vue (galaxyproject#9147). Implements galaxyproject#9111 - part of https://github.com/galaxyproject/galaxy/projects/15 and outlined in http://bit.ly/simplified-workflow-ui. What is in the PR: - Add new Galaxy configuration option - ``simplified_workflow_run_ui`` set to ``off`` by default. - If instead the admin has set this parameter to ``prefer``, on the workflow run page scan the workflow run request and if three conditions are met show a simplfied tool form. These conditions are: - No workflow "resource parameters" - pretty niche, not documented, I don't think anyone outside of Canada is using them and even them I'm not sure if they ever got to production. - No "open" tools (i.e. tools with disconnected runtime inputs). - No "replacement parameters" defined outside PJAs. I'm calling #{} inside PJA and ${} inside tool steps both "replacement parameters" because the user populates them the same way in the GUI. The API only handles them inside the context of the PJA - it seems the GUI is responsible for replacing them at runtime in the traditional form. - The simplified workflow form: - Drops tool and subworkflow steps from rendering all together and instead just renders the inputs. These are not rendered as separate "steps" or forms - but as just different inputs the same clean, simple form (more the like tool GUI). Labels (or step indexes as a fallback) are used at the input name, step annotations are used as the input help text. - Simplify the workflow request made by the client - send only replacement parameters and inputs - do not serialize tool state for each module. I think this makes what we are tracking more structured and should be more performant as well. Prevents storing HDA IDs in unstructured JSON blobs in the database as well. - Drops history target option to simplify the UI - simplified_workflow_run_ui_target_history can be set to either 'current' or 'new' to adjust this parameter Galaxy-wide for the simplified form. - Drops job caching option to simplify the UI - simplified_workflow_run_ui_cache can be set to 'off' or 'on' to change this parameter Galaxy-wide for the simplified form. - Drops resource parameters - we've already verified there are none for simplified workflows.

bgruening · 2020-08-14T19:58:40Z

Awesome! Yeah!!!!

TKlingstrom · 2020-08-14T20:19:54Z

Wow thanks Jon for doing this and other people commenting, I really look forward to testing things.

(Also hugely sorry for disappearing and not doing anything for half a year, I do not control time in my my work life nor my private life as much as I would like but it's moving in the right direction at least).

afgane · 2020-08-14T23:01:29Z

This is indeed excellent. Nonetheless, 3 comments:

The config values are not included in galaxy.yml.sample
If there is a link to switch to the full workflow form, it feels it should be a toggle so you can switch back to the simplified view
It would be great to include the workflow annotation text at the top of the run form

bgruening · 2020-08-15T07:49:10Z

@afgane can you create a new issue with those ideas, please. I think we can iterate here with many other small things. We also discussed briefly to include maybe a small image of the workflow etc.

mvdbeek · 2020-08-20T12:29:52Z

Looks like the input step parameters are not actually sent in the simplified form:

{"replacement_dict":{},"inputs":{"0":{"values":[{"hid":1,"id":"db210f2338fbfc8b","keep":false,"name":"Pasted Entry","src":"hda","tags":[]}],"batch":false}},"inputs_by":"step_index","batch":true,"use_cached_job":false,"history_id":"6169422af4f6057a"}

@jmchilton do you know of the top of your head what's going on here ?

mvdbeek · 2020-08-20T12:40:50Z

Got it, https://github.com/galaxyproject/galaxy/blob/dev/client/src/components/Workflow/Run/WorkflowRunFormSimple.vue#L88 doesn't include parameter_input, I'll have a fix in a minute

galaxybot added triage status/WIP labels Dec 19, 2019

jmchilton force-pushed the simplified_run branch from f6f6b1d to 6abef9d Compare December 19, 2019 23:28

jmchilton added area/UI-UX area/workflows kind/feature and removed triage labels Dec 19, 2019

jmchilton force-pushed the simplified_run branch from 6abef9d to 4fcfb76 Compare December 19, 2019 23:45

guerler reviewed Jan 2, 2020

View reviewed changes

client/galaxy/scripts/components/WaitButton.vue Outdated Show resolved Hide resolved

guerler reviewed Jan 2, 2020

View reviewed changes

client/galaxy/scripts/components/Workflow/Run/WorkflowRun.vue Outdated Show resolved Hide resolved

jmchilton force-pushed the simplified_run branch from 4fcfb76 to 83a62e3 Compare January 3, 2020 16:49

jmchilton force-pushed the simplified_run branch from 83a62e3 to fcffe34 Compare January 30, 2020 15:20

jmchilton added a commit to jmchilton/galaxy that referenced this pull request Jan 30, 2020

Change ref name to simplify access.

86356e3

Based on PR review comments ( galaxyproject#9151 (comment) ).

jmchilton force-pushed the simplified_run branch from fcffe34 to a686e46 Compare January 30, 2020 18:08

jmchilton added a commit to jmchilton/galaxy that referenced this pull request Feb 18, 2020

Change ref name to simplify access.

509aa75

Based on PR review comments ( galaxyproject#9151 (comment) ).

jmchilton added a commit to jmchilton/galaxy that referenced this pull request Mar 20, 2020

Change ref name to simplify access.

0640dfa

Based on PR review comments ( galaxyproject#9151 (comment) ).

jmchilton added a commit to jmchilton/galaxy that referenced this pull request Apr 20, 2020

Change ref name to simplify access.

4510724

Based on PR review comments ( galaxyproject#9151 (comment) ).

jmchilton force-pushed the simplified_run branch from a686e46 to e44ea17 Compare May 11, 2020 15:59

jmchilton force-pushed the simplified_run branch from e44ea17 to 828c37c Compare June 1, 2020 14:30

jmchilton force-pushed the simplified_run branch 5 times, most recently from 440835c to a2c43f3 Compare August 11, 2020 00:22

jmchilton force-pushed the simplified_run branch 2 times, most recently from 646a4fa to 2f01417 Compare August 11, 2020 16:04

guerler reviewed Aug 11, 2020

View reviewed changes

client/galaxy/scripts/components/Workflow/Run/WorkflowRun.vue Outdated Show resolved Hide resolved

jmchilton force-pushed the simplified_run branch 3 times, most recently from 9fd5ad2 to 7c0b28c Compare August 12, 2020 03:59

jmchilton changed the title ~~[WIP] Simplified Workflow Run Form~~ Simplified Workflow Run Form Aug 12, 2020

jmchilton removed the status/WIP label Aug 12, 2020

galaxybot added this to the 20.09 milestone Aug 12, 2020

bgruening approved these changes Aug 13, 2020

View reviewed changes

dannon reviewed Aug 13, 2020

View reviewed changes

client/src/components/Workflow/Run/WorkflowRunFormSimple.vue Outdated Show resolved Hide resolved

dannon reviewed Aug 13, 2020

View reviewed changes

client/src/components/Workflow/Run/WorkflowRunFormSimple.vue Outdated Show resolved Hide resolved

dannon reviewed Aug 13, 2020

View reviewed changes

client/src/components/Workflow/Run/WorkflowRunFormSimple.vue Outdated Show resolved Hide resolved

jmchilton force-pushed the simplified_run branch from 7c0b28c to 4626f71 Compare August 13, 2020 19:43

dannon merged commit 246603a into galaxyproject:dev Aug 14, 2020

afgane mentioned this pull request Aug 19, 2020

Improvements to the simplified workflow run UI #10128

Open

mvdbeek mentioned this pull request Aug 20, 2020

Fix parameter_input dropped in new workflow form #10135

Merged

hexylena mentioned this pull request Oct 5, 2020

Simplified Workflow Run Component #9111

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Simplified Workflow Run Form #9151

Simplified Workflow Run Form #9151

jmchilton commented Dec 19, 2019 •

edited by nsoranzo

Loading

nsoranzo commented Dec 20, 2019

bgruening commented Aug 9, 2020

dannon commented Aug 11, 2020 •

edited

Loading

jmchilton commented Aug 11, 2020

dannon commented Aug 11, 2020

guerler commented Aug 11, 2020 •

edited

Loading

bgruening left a comment

dannon Aug 13, 2020 •

edited

Loading

jmchilton Aug 13, 2020

dannon Aug 13, 2020 •

edited

Loading

jmchilton commented Aug 13, 2020

bgruening commented Aug 14, 2020

TKlingstrom commented Aug 14, 2020 •

edited

Loading

afgane commented Aug 14, 2020

bgruening commented Aug 15, 2020

mvdbeek commented Aug 20, 2020

mvdbeek commented Aug 20, 2020

Simplified Workflow Run Form #9151

Simplified Workflow Run Form #9151

Conversation

jmchilton commented Dec 19, 2019 • edited by nsoranzo Loading

What is in the PR:

Screenshots

nsoranzo commented Dec 20, 2019

bgruening commented Aug 9, 2020

dannon commented Aug 11, 2020 • edited Loading

jmchilton commented Aug 11, 2020

dannon commented Aug 11, 2020

guerler commented Aug 11, 2020 • edited Loading

bgruening left a comment

Choose a reason for hiding this comment

dannon Aug 13, 2020 • edited Loading

Choose a reason for hiding this comment

jmchilton Aug 13, 2020

Choose a reason for hiding this comment

dannon Aug 13, 2020 • edited Loading

Choose a reason for hiding this comment

jmchilton commented Aug 13, 2020

bgruening commented Aug 14, 2020

TKlingstrom commented Aug 14, 2020 • edited Loading

afgane commented Aug 14, 2020

bgruening commented Aug 15, 2020

mvdbeek commented Aug 20, 2020

mvdbeek commented Aug 20, 2020

jmchilton commented Dec 19, 2019 •

edited by nsoranzo

Loading

dannon commented Aug 11, 2020 •

edited

Loading

guerler commented Aug 11, 2020 •

edited

Loading

dannon Aug 13, 2020 •

edited

Loading

dannon Aug 13, 2020 •

edited

Loading

TKlingstrom commented Aug 14, 2020 •

edited

Loading