Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a Passwort Strength Component for User Registration #19355

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

Csaern
Copy link

@Csaern Csaern commented Dec 19, 2024

As a project I made a password strength component to visualize the strength of a password used to create an account for the galaxy server. The user gets feedback for his input at the registration site. I also added a button for password guidelines, to show users, what components they need to get a strong password.

PW_Galaxy_1
PW_Galaxy_2
PW_Galaxy_3

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@nsoranzo
Copy link
Member

Thanks for working on this feature! Two suggestions:

  • Add the "eye" functionality to the password field to allow the uses to view what they are typing if it's safe to do so
  • Replace the Password Guidelines button with a simple help text containing the few rules we actually enforce and a link to general-purpose guidelines like https://www.cisa.gov/secure-our-world/use-strong-passwords

@guerler
Copy link
Contributor

guerler commented Dec 19, 2024

I agree with @nsoranzo, and would additionally suggest that you could add a checkmark to each fulfilled criteria listed in the help section. Thank you for working on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants