[24.2] Fix handling of step id offsets when duplicating selections #19351
+39
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdbeek
reviewed
Dec 20, 2024
|
|
||
| Object.values(data.steps).forEach((step) => { | ||
| // Since we are resigning IDs based on index, ensure correct ordering | ||
| stepArray.sort((a, b) => a.id - b.id); |
There was a problem hiding this comment.
Wouldn't you want to use the order_index for this ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ids were incremented by too much when the duplicated partial Workflow passed to the
fromSimplefunction contained Ids, which did not start at 0, and could cause gaps in the workflows step ids. This was an unreachable state before selection duplication, which is why this bug appeared now.How to test the changes?
(Select all options that apply)
License