Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.1] Backport #19001 kubernetes api client fix #19338

Merged
merged 4 commits into from
Dec 17, 2024
Merged

[24.1] Backport #19001 kubernetes api client fix #19338

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
25db34e
Account that k8s pods may be uncounted yet.
mapk-amazon Oct 15, 2024
cbeedf3
Fix linting
mapk-amazon Oct 15, 2024
c311092
Update lib/galaxy/jobs/runners/kubernetes.py
mapk-amazon Oct 16, 2024
df1bb9a
Update lib/galaxy/jobs/runners/kubernetes.py
mapk-amazon Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/galaxy/jobs/runners/kubernetes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -736,7 +736,10 @@ def check_watched_item(self, job_state):
# as probably this means that the k8s API server hasn't
# had time to fill in the object status since the
# job was created only too recently.
if len(job.obj["status"]) == 0:
# It is possible that k8s didn't account for the status of the pods
# and they are in the uncountedTerminatedPods status. In this
# case we also need to wait a moment
if len(job.obj["status"]) == 0 or job.obj["status"].get("uncountedTerminatedPods"):
return job_state
if "succeeded" in job.obj["status"]:
succeeded = job.obj["status"]["succeeded"]
Expand Down
Loading