Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.2] Fix activity-bar-id handling wrt activityStore #19316

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

dannon
Copy link
Member

@dannon dannon commented Dec 11, 2024

Debugging something else, I noticed that we were creating extraneous/duplicate activity stores. There should be two, the new workflow editor bar and the default (analysis view) bar. We were unintentionally creating separate ones for upload, notifications, and interactive tools due to reuse of the wrong 'id' to name the store.

I'm not positive this was causing specific issues, but I wouldn't be surprised if it was to blame for some categories of glitches in changing activities and clicking on the bar.

Example of duplicate store arrangement/contents:

image

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 25.0 milestone Dec 11, 2024
@dannon dannon modified the milestones: 25.0, 24.2 Dec 11, 2024
@dannon dannon changed the title [24.2] Fix activity-bar-id handling [24.2] Fix activity-bar-id handling wrt activityStore Dec 11, 2024
@davelopez davelopez merged commit 3fec678 into galaxyproject:release_24.2 Dec 12, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants