[24.2] Fix activity-bar-id handling wrt activityStore #19316
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debugging something else, I noticed that we were creating extraneous/duplicate activity stores. There should be two, the new workflow editor bar and the default (analysis view) bar. We were unintentionally creating separate ones for upload, notifications, and interactive tools due to reuse of the wrong 'id' to name the store.
I'm not positive this was causing specific issues, but I wouldn't be surprised if it was to blame for some categories of glitches in changing activities and clicking on the bar.
Example of duplicate store arrangement/contents:
How to test the changes?
(Select all options that apply)
License