[24.2] Cleanup "typical" usage of list of pairs builder. #19253
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#19248 is much more straight forward set of usability fixes for people who have messy data or data not prepped in a history for pairing. This PR cleans up the usage of the builder for users who have done everything right - they have preserved filenames with a common pattern we recognize, the datasets can be paired, and (optionally) they've selected only data they want to include in the collection. For this use case - the pair builder should just do what is needed by default and showing the pairing interface and its warning is messy and the showing the matching is... well fine... but not as clear as it could be if we weren't going to be doing pairing. For these users, I think they want to just give the collection a name and move one. This makes that a lot more clean.
If the user makes a selection that only includes pairable datasets:
In other contexts like auto-populating this from a history or a user mis-click - an additional little box shows the unmatched datasets - I think this is important for knowing what happens.
In most cases, hopefully the user can just review the table and move on. If there is an issue - there are two links to clarify what went wrong. If the problem is just with the identifiers and not the matching - we can switch the builder but hide the matching part (something added this release I think).
This component also deals with space better than the full builder and keeps the modal a reasonable size (bypassing #19249 or typical use cases).
How to test the changes?
(Select all options that apply)
License