Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.2] Cleanup "typical" usage of list of pairs builder. #19253

Draft
wants to merge 5 commits into
base: release_24.2
Choose a base branch
from

Conversation

jmchilton
Copy link
Member

#19248 is much more straight forward set of usability fixes for people who have messy data or data not prepped in a history for pairing. This PR cleans up the usage of the builder for users who have done everything right - they have preserved filenames with a common pattern we recognize, the datasets can be paired, and (optionally) they've selected only data they want to include in the collection. For this use case - the pair builder should just do what is needed by default and showing the pairing interface and its warning is messy and the showing the matching is... well fine... but not as clear as it could be if we weren't going to be doing pairing. For these users, I think they want to just give the collection a name and move one. This makes that a lot more clean.

If the user makes a selection that only includes pairable datasets:

Screenshot 2024-12-04 at 4 09 31 PM

In other contexts like auto-populating this from a history or a user mis-click - an additional little box shows the unmatched datasets - I think this is important for knowing what happens.

Screenshot 2024-12-04 at 4 09 15 PM

In most cases, hopefully the user can just review the table and move on. If there is an issue - there are two links to clarify what went wrong. If the problem is just with the identifiers and not the matching - we can switch the builder but hide the matching part (something added this release I think).

This component also deals with space better than the full builder and keeps the modal a reasonable size (bypassing #19249 or typical use cases).

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. use cases and screenshots above above describe how to test

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Disable the button and make it clear in the message it has to do with empty filters.
How is a shade of green so evocative of a time.
It results in hiding all the data and a scary red messages when the user did literally nothing wrong. I think this is single biggest issue - it makes it seem like you cannot just manually pair these quickly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant