[24.2] Improve the empty history message for guiding users to collections.

[jmchilton]

A driving motivator for the issue was initial impressions and histories without datasets and history-less landing pages. Just displaying a page about no datasets without regard to how to resolve that seems bad in all of those cases.

Maybe this was not intentional though because if you have some initial datasets - you get a second column with the ability to add more. Maybe just swapping to that column by default might be better instead of the message. If that is the case - feel free to treat this as a bug report and close this out.

How to test the changes?

(Select all options that apply)

• Instructions for manual testing are as follows:
  1. Create a workflow with a list input, navigate to it with an empty history, and click the new orange button.

License

• I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

[ahmedhamidawan]

Tried this locally with the openGlobalUploadModal method you've added here, and will say it does work out pretty nicely; no datasets, well, just upload some using the upload modal, then close that out to see the uploaded ones in the builder.

But since the CollectionCreatorModal already has the "Upload Files to Add to Collection" tab, maybe the better approach is to simply have that tab available still (like you mentioned)?

[jmchilton]

@ahmedhamidawan - it is your component - if you'd like to put the extra work into getting that tab to appear and work then go for it. Conflicting upload modals if a mess to be sure. It sounds like that would be a better user experience - I just wanted to make sure we had something better than just that text before the 24.2 release.

[ahmedhamidawan]

@jmchilton Here is an implementation:

no_items_collection_builder.mp4

If this looks good, should I just push this commit to ur branch?
we could

• keep ur current commit
• or I (or you) could rebase and remove it

[ahmedhamidawan]

I have pushed the commit
You could take a look and we could remove it/adjust for any changes etc.?

[jmchilton]

Absolutely lovely - way better than my hack!

[jmchilton]

@ahmedhamidawan I opened the PR so I cannot merge this but you can! You've got a +1 from me on your changes.

[ahmedhamidawan]

Thank you for pointing this out John!