-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[24.2] Backport of Workflow Editor Activity Bar #19212
Merged
jdavcs
merged 132 commits into
galaxyproject:release_24.2
from
dannon:workflow-editor-activity-bar
Dec 4, 2024
Merged
[24.2] Backport of Workflow Editor Activity Bar #19212
jdavcs
merged 132 commits into
galaxyproject:release_24.2
from
dannon:workflow-editor-activity-bar
Dec 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/UI-UX
area/testing
area/database
Galaxy's database or data access layer
area/testing/integration
area/testing/selenium
labels
Nov 27, 2024
Re-ran the client tests and they passed but now it needs rebase because of that jerk @jmchilton - sorry about that. |
dannon
force-pushed
the
workflow-editor-activity-bar
branch
from
November 27, 2024 19:27
c151605
to
d55b5f3
Compare
debounce sync to avoid staggered calls pass activity bar id where needed
make delayed input v-model compliant
add types fix type errors remove redundant code remove any unify naming
make workflow card mostly stateless move modals outside of workflow card
add missing actions to dropdown
remove unused css fix broken css add non-found indicator
After refactoring `move MarkdownEditor to activity bar`
dannon
force-pushed
the
workflow-editor-activity-bar
branch
from
December 3, 2024 15:27
d55b5f3
to
85bde64
Compare
4 tasks
@ElectronicBlueberry Thanks for fixing that up -- I think this is good to go now. |
This PR was merged without a "kind/" label, please correct. |
jdavcs
added
kind/feature
highlight
Included in user-facing release notes at the top
labels
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/database
Galaxy's database or data access layer
area/testing/integration
area/testing/selenium
area/testing
area/UI-UX
highlight
Included in user-facing release notes at the top
kind/feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #18729
Resolved several conflicts in the rebase, including in various jest tests; it'd be good to let the suite run here. Take care merging this forward.
How to test the changes?
(Select all options that apply)
License