Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't calculate dataset hash for datasets in non-OK state #19191

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

nsoranzo
Copy link
Member

@nsoranzo nsoranzo commented Nov 23, 2024

Also:

  • Check again that the dataset hasn't been purged right before hash calculation starts.

Address comments in
https://github.com/galaxyproject/galaxy/pull/19181/files#r1853605980

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Also:
- Check again that the dataset hasn't been purged right before
  hash calculation starts.

Address comments in
https://github.com/galaxyproject/galaxy/pull/19181/files#r1853605980
@nsoranzo nsoranzo requested a review from mvdbeek November 23, 2024 10:33
@github-actions github-actions bot added this to the 25.0 milestone Nov 23, 2024
@mvdbeek mvdbeek merged commit eed1908 into galaxyproject:dev Nov 25, 2024
54 of 55 checks passed
@mvdbeek
Copy link
Member

mvdbeek commented Nov 25, 2024

Thank you!

@nsoranzo nsoranzo deleted the 19181_followup branch November 25, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants