Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Python dependencies #19190

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

galaxybot
Copy link
Contributor

by running make update-dependencies.

@nsoranzo
Copy link
Member

@davelopez Any idea about this error?

RuntimeError: Cannot update undefined schema for $ref=#/components/schemas/galaxy__schema__notifications__PersonalNotificationCategory-Input__1

Traceback in https://github.com/galaxyproject/galaxy/actions/runs/11983603557/job/33413355009?pr=19190 (and others).

@davelopez
Copy link
Contributor

Hmmm I've never seen that one before, likely something changed in the new Pydantic version that our custom OpenAPI schema generation, FastAPI schema generation, or a combination of them broke it 🤔

field_mapping, definitions = get_definitions(

I'll try to investigate... 🔎

@nsoranzo
Copy link
Member

Hmmm I've never seen that one before, likely something changed in the new Pydantic version that our custom OpenAPI schema generation, FastAPI schema generation, or a combination of them broke it 🤔

field_mapping, definitions = get_definitions(

I'll try to investigate... 🔎

Thanks! 🙏

@davelopez
Copy link
Contributor

It looks like this is the issue pydantic/pydantic#10960

The PersonalNotificationCategory enum is used as a key of PersonalNotificationPreferences here:

PersonalNotificationPreferences = Dict[PersonalNotificationCategory, NotificationCategorySettings]

We can pin pydantic for now or wait a bit if the fix is coming soon.

@nsoranzo
Copy link
Member

Thanks for looking into this @davelopez !
Let's see if the pydantic issue gets fixed fast, otherwise we can pin it.
In the meantime I still have 280 UP031 errors to fix for the Python linting 😆

@galaxybot galaxybot force-pushed the dev_auto_update_dependencies branch 2 times, most recently from 3d3f5d9 to 0b0eb08 Compare December 4, 2024 01:11
@davelopez
Copy link
Contributor

The pydantic issue should be fixed in https://github.com/pydantic/pydantic/releases/tag/v2.10.3

@nsoranzo
Copy link
Member

nsoranzo commented Dec 4, 2024

The pydantic issue should be fixed in https://github.com/pydantic/pydantic/releases/tag/v2.10.3

Yes, I noticed yesterday and already re-run the update process. The previous issue is indeed solved, although we need to update the OpenAPI schemas and fix some type annotation issues due to the new pydantic.

Something else is now breaking the ToolShed tests though (and I am not yet finished fixing the new UP031 errors), so it may be worth to split out the pydantic update and related fixes in a separate PR.

@galaxybot galaxybot force-pushed the dev_auto_update_dependencies branch 2 times, most recently from b674064 to 7686e38 Compare December 14, 2024 03:17
@galaxybot galaxybot force-pushed the dev_auto_update_dependencies branch from 7686e38 to 3d2257b Compare December 16, 2024 17:15
galaxybot and others added 2 commits December 17, 2024 15:35
by running `make update-dependencies`.
@nsoranzo nsoranzo force-pushed the dev_auto_update_dependencies branch from 3d2257b to 3546ae5 Compare December 17, 2024 15:35
@nsoranzo
Copy link
Member

Test failures unrelated (at last!)

@nsoranzo nsoranzo requested a review from a team December 17, 2024 17:51
@nsoranzo nsoranzo merged commit 4c44920 into galaxyproject:dev Dec 18, 2024
50 of 55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants