-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Python dependencies #19190
Update Python dependencies #19190
Conversation
@davelopez Any idea about this error?
Traceback in https://github.com/galaxyproject/galaxy/actions/runs/11983603557/job/33413355009?pr=19190 (and others). |
Hmmm I've never seen that one before, likely something changed in the new Pydantic version that our custom OpenAPI schema generation, FastAPI schema generation, or a combination of them broke it 🤔
I'll try to investigate... 🔎 |
Thanks! 🙏 |
It looks like this is the issue pydantic/pydantic#10960 The galaxy/lib/galaxy/schema/notifications.py Line 463 in 7a68911
We can pin pydantic for now or wait a bit if the fix is coming soon. |
Thanks for looking into this @davelopez ! |
3d3f5d9
to
0b0eb08
Compare
The pydantic issue should be fixed in https://github.com/pydantic/pydantic/releases/tag/v2.10.3 |
Yes, I noticed yesterday and already re-run the update process. The previous issue is indeed solved, although we need to update the OpenAPI schemas and fix some type annotation issues due to the new pydantic. Something else is now breaking the ToolShed tests though (and I am not yet finished fixing the new UP031 errors), so it may be worth to split out the pydantic update and related fixes in a separate PR. |
b674064
to
7686e38
Compare
7686e38
to
3d2257b
Compare
by running `make update-dependencies`.
It was made positional-only in commit: noxdafox/pebble@6a12ddf
3d2257b
to
3546ae5
Compare
Test failures unrelated (at last!) |
by running
make update-dependencies
.