-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow a posix file source to prefer linking. #19132
Conversation
e0fc1d0
to
4aad8ca
Compare
The linking upload parameters will still be respected, but if none of them are set data fetch will default to just linking files during upload. This uses Dataset.external_filename instead of symlinks in the objectstore so that Galaxy has better tracking of the links and so this works closer to the way data libraries have always worked.
4aad8ca
to
5e00ffe
Compare
Thank you @jmchilton. I tried this and ran into an issue. The upload works fine and the dataset looks good but when attempting to run a job with that linked dataset the tool cannot find the input file. |
I've added a test case for running a tool afterward and it works fine... I'm going to have to gulp... use Galaxy... aren't I? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
The linking upload parameters will still be respected, but if none of them are set data fetch will default to just linking files during upload. This uses Dataset.external_filename instead of symlinks in the objectstore so that Galaxy has better tracking of the links and so this works closer to the way data libraries have always worked.
Alternative to #19125.
How to test the changes?
(Select all options that apply)
License