Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid persisting credentials on checkout step of the Github actions #19089

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/api.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ jobs:
- uses: actions/checkout@v4
with:
path: 'galaxy root'
persist-credentials: false
- uses: actions/setup-node@v4
with:
node-version: '18.12.1'
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/bioblend.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,13 @@ jobs:
with:
fetch-depth: 1
path: galaxy
persist-credentials: false
- name: Checkout Bioblend
uses: actions/checkout@v4
with:
repository: galaxyproject/bioblend
path: bioblend
persist-credentials: false
- name: Cache pip dir
uses: actions/cache@v4
with:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/build_client.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ jobs:
- uses: actions/checkout@v4
with:
path: 'galaxy root'
persist-credentials: false
- uses: actions/setup-node@v4
with:
node-version: '18.12.1'
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/build_container_image.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
persist-credentials: false
# https://stackoverflow.com/questions/59810838/how-to-get-the-short-sha-for-the-github-workflow
- name: Set outputs
id: commit
Expand Down Expand Up @@ -75,6 +77,8 @@ jobs:
if: github.repository_owner == 'galaxyproject'
steps:
- uses: actions/checkout@v4
with:
persist-credentials: false
# https://stackoverflow.com/questions/59810838/how-to-get-the-short-sha-for-the-github-workflow
- name: Set outputs
id: commit
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/check_test_class_names.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ jobs:
python-version: ['3.8']
steps:
- uses: actions/checkout@v4
with:
persist-credentials: false
- uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/codeql-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ jobs:
steps:
- name: Checkout repository
uses: actions/checkout@v4
with:
persist-credentials: false

# Initializes the CodeQL tools for scanning.
- name: Initialize CodeQL
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/converter_tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ jobs:
- uses: actions/checkout@v4
with:
path: 'galaxy root'
persist-credentials: false
- uses: actions/setup-node@v4
with:
node-version: '18.12.1'
Expand All @@ -41,6 +42,7 @@ jobs:
with:
repository: galaxyproject/galaxy-test-data
path: galaxy-test-data
persist-credentials: false
- uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/cwl_conformance.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ jobs:
- uses: actions/checkout@v4
with:
path: 'galaxy root'
persist-credentials: false
- uses: actions/setup-node@v4
with:
node-version: '18.12.1'
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/db_indexes.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ jobs:
- uses: actions/checkout@v4
with:
path: 'galaxy root'
persist-credentials: false
- uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/dependencies.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
persist-credentials: false
# Install Python 3.8 for update_lint_requirements.sh
# Install Python 3.9 (as default) to allow `uv lock` to generate metadata for rucio-clients
- uses: actions/setup-python@v5
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ jobs:
- uses: actions/checkout@v4
with:
fetch-depth: 0
persist-credentials: false
- uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/docs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ jobs:
- uses: actions/checkout@v4
with:
fetch-depth: 0
persist-credentials: false
- uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/first_startup.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ jobs:
- uses: actions/checkout@v4
with:
path: 'galaxy root'
persist-credentials: false
- uses: actions/setup-node@v4
with:
node-version: '18.12.1'
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/framework_tools.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ jobs:
- uses: actions/checkout@v4
with:
path: 'galaxy root'
persist-credentials: false
- uses: actions/setup-node@v4
with:
node-version: '18.12.1'
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/framework_workflows.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ jobs:
- uses: actions/checkout@v4
with:
path: 'galaxy root'
persist-credentials: false
- uses: actions/setup-node@v4
with:
node-version: '18.12.1'
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/integration.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ jobs:
- uses: actions/checkout@v4
with:
path: 'galaxy root'
persist-credentials: false
- uses: actions/setup-node@v4
with:
node-version: '18.12.1'
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/integration_selenium.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ jobs:
- uses: actions/checkout@v4
with:
path: 'galaxy root'
persist-credentials: false
- uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/jest.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ jobs:
node: [18]
steps:
- uses: actions/checkout@v4
with:
persist-credentials: false
- name: Setup node
uses: actions/setup-node@v4
with:
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/js_lint.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ jobs:
node: [18]
steps:
- uses: actions/checkout@v4
with:
persist-credentials: false
- name: Setup node
uses: actions/setup-node@v4
with:
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/lint.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ jobs:
CORE_PATH: 'lib/galaxy/dependencies/pinned-requirements.txt'
steps:
- uses: actions/checkout@v4
with:
persist-credentials: false
- uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/lint_openapi_schema.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ jobs:
- uses: actions/checkout@v4
with:
path: 'galaxy root'
persist-credentials: false
- uses: actions/setup-node@v4
with:
node-version: '18.12.1'
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/mulled.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ jobs:
- uses: actions/checkout@v4
with:
path: 'galaxy root'
persist-credentials: false
- uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/osx_startup.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ jobs:
- uses: actions/checkout@v4
with:
path: 'galaxy root'
persist-credentials: false
- uses: actions/setup-node@v4
with:
node-version: '18.12.1'
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/performance.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ jobs:
- uses: actions/checkout@v4
with:
path: 'galaxy root'
persist-credentials: false
- uses: actions/setup-node@v4
with:
node-version: '18.12.1'
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/publish_artifacts.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ jobs:
with:
python-version: ${{ matrix.python-version }}
- uses: actions/checkout@v4
with:
persist-credentials: false
- name: Install script dependencies
run: pip install galaxy-release-util
- name: Build and publish
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/reports_startup.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ jobs:
- uses: actions/checkout@v4
with:
path: 'galaxy root'
persist-credentials: false
- uses: actions/setup-node@v4
with:
node-version: '18.12.1'
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/selenium.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ jobs:
- uses: actions/checkout@v4
with:
path: 'galaxy root'
persist-credentials: false
- uses: actions/setup-node@v4
with:
node-version: '18.12.1'
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/test_galaxy_packages.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ jobs:
- uses: actions/checkout@v4
with:
path: 'galaxy root'
persist-credentials: false
- uses: actions/setup-node@v4
with:
node-version: '18.12.1'
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/test_galaxy_packages_for_pulsar.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ jobs:
- uses: actions/checkout@v4
with:
path: 'galaxy root'
persist-credentials: false
- uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/test_galaxy_release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,6 @@ jobs:
- uses: actions/checkout@v4
with:
fetch-depth: 0
persist-credentials: false
- name: Run tests
run: ./test/release.sh
1 change: 1 addition & 0 deletions .github/workflows/toolshed.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ jobs:
- uses: actions/checkout@v4
with:
path: 'galaxy root'
persist-credentials: false
- uses: actions/setup-node@v4
with:
node-version: '18.12.1'
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/unit-postgres.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ jobs:
- uses: actions/checkout@v4
with:
path: 'galaxy root'
persist-credentials: false
- uses: actions/setup-node@v4
with:
node-version: '18.12.1'
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/unit.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ jobs:
- uses: actions/checkout@v4
with:
path: 'galaxy root'
persist-credentials: false
- uses: actions/setup-node@v4
with:
node-version: '18.12.1'
Expand Down
Loading