Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.0] Fetch invocation id only once on the job info page #19079

Merged
merged 2 commits into from
Oct 31, 2024
Merged

[24.0] Fetch invocation id only once on the job info page #19079

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb65bb8
[24.0] Fetch invocation id only once on the job info page
ahmedhamidawan Oct 29, 2024
2cae82c
use a watcher to fetch invocation id just once
ahmedhamidawan Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 16 additions & 12 deletions client/src/components/JobInformation/JobInformation.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,15 @@ import { JobDetailsProvider } from "components/providers/JobProvider";
import UtcDate from "components/UtcDate";
import { formatDuration, intervalToDuration } from "date-fns";
import JOB_STATES_MODEL from "utils/job-states-model";
import { computed, ref } from "vue";
import { computed, ref, watch } from "vue";

import { invocationForJob } from "@/api/invocations";

import DecodedId from "../DecodedId.vue";
import CodeRow from "./CodeRow.vue";

const job = ref(null);
const invocationId = ref(null);
const invocationId = ref(undefined);

const props = defineProps({
job_id: {
Expand Down Expand Up @@ -41,9 +41,6 @@ const metadataDetail = ref({

function updateJob(newJob) {
job.value = newJob;
if (newJob) {
fetchInvocation(newJob.id);
}
}

function filterMetadata(jobMessages) {
Expand All @@ -57,14 +54,21 @@ function filterMetadata(jobMessages) {
});
}

async function fetchInvocation(jobId) {
if (jobId) {
const invocation = await invocationForJob({ jobId: jobId });
if (invocation) {
invocationId.value = invocation.id;
// Fetches the invocation for the given job id to get the associated invocation id
watch(
() => props.job_id,
async (newId, oldId) => {
if (newId && (invocationId.value === undefined || newId !== oldId)) {
const invocation = await invocationForJob({ jobId: newId });
if (invocation) {
invocationId.value = invocation.id;
} else {
invocationId.value = null;
}
}
}
}
},
{ immediate: true }
);
</script>

<template>
Expand Down
Loading