Add job metrics per invocation #19048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdbeek
force-pushed
the
invocation_metrics_api
branch
2 times, most recently
from
e41e3cb to
42e56ff
Compare
mvdbeek
force-pushed
the
invocation_metrics_api
branch
from
42e56ff to
28975da
Compare
mvdbeek
force-pushed
the
invocation_metrics_api
branch
from
28975da to
fad5ae5
Compare
mvdbeek
force-pushed
the
invocation_metrics_api
branch
from
fad5ae5 to
6b94267
Compare
|
This is very cool! |
mvdbeek
force-pushed
the
invocation_metrics_api
branch
from
9916da2 to
b1691c5
Compare
Comment on lines
+104
to
+106
| "vega": "^5.30.0", | ||
| "vega-embed": "^6.26.0", | ||
| "vega-lite": "^5.21.0", |
There was a problem hiding this comment.
Since this is only needed in a few places, and quite a large package, could we load this on demand?
There was a problem hiding this comment.
I suppose if you ask then it is possible 😃 ? I don't know how to do that though.
There was a problem hiding this comment.
I can push a commit if you like
There was a problem hiding this comment.
To explain what's happening here, to anyone curious:
- the vega libs were added to "modulesExcludedFromLibs" so it's not bundled into the libs bundle. This adds these libs to their own bundles.
- type imports were changes from
import { type ...}toimport type { ... }. These are not equivalent. The second one let's typescript completely remove the import line, while the first keeps an empty import, in case of import side effects. This would break on demand loading - Finally the component is imported as
const VegaWrapper = () => import("./VegaWrapper.vue");. This is a way to lazy load vue components and all it's related code (the vega library in this case). The component can be used like before
|
Thanks @mvdbeek and @ElectronicBlueberry ... great feature! |
ElectronicBlueberry
approved these changes
Nov 6, 2024
|
This PR was merged without a "kind/" label, please correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows quickly summarizing runtime, memory usage, cores etc. per invocation:
How to test the changes?
(Select all options that apply)
License