Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow recovering a normalized version of workflow request state from API #18985

Merged
merged 4 commits into from
Oct 28, 2024

Conversation

jmchilton
Copy link
Member

Implements #18981

Also made small improvements to the schema for running workflows. Filled in a bunch of stub descriptions, dropped step_parameters which never existed in the API. There is a random check that it isn't in the request because it a field that is included in the test format - but it shouldn't have been part of the schema.

How to test the changes?

(Select all options that apply)

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@jmchilton
Copy link
Member Author

I've included a sort of breaking change to the workflow invocation API here - it is isolated to cc8f1b6. If you call a workflow by workflow ID and not a stored workflow ID - I think you should run that workflow and not the latest workflow. It feels quite jarring to say this is the particular instance ID I want to run and then get the latest version IMO. In either case if you explicitly pass a version - it will still run the workflow at that version.

@jmchilton jmchilton marked this pull request as ready for review October 15, 2024 15:49
@github-actions github-actions bot added this to the 24.2 milestone Oct 15, 2024
@jmchilton jmchilton mentioned this pull request Oct 22, 2024
4 tasks
@jmchilton
Copy link
Member Author

Rerunning a failed test here - I haven't seen this before and it might be related.

FAILED test/integration/test_workflow_refactoring.py::TestWorkflowRefactoringIntegration::test_upgrade_all_steps - AssertionError: assert '0.1.0' == '0.1.1'
  - 0.1.1
  ?     ^
  + 0.1.0
  ?     ^

@mvdbeek
Copy link
Member

mvdbeek commented Oct 28, 2024

I have seen this quite a few times, I don't think it's related

@mvdbeek mvdbeek merged commit 1ebd078 into galaxyproject:dev Oct 28, 2024
55 of 58 checks passed
@mvdbeek
Copy link
Member

mvdbeek commented Oct 28, 2024

This is excellent, thanks a lot @jmchilton!

@ahmedhamidawan ahmedhamidawan added the highlight/dev Included in admin/dev release notes label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants