[24.1] Display binary data even if text data is expected

[mvdbeek]

I've been going back and forth on whether we should raise an exception or not, however I think the advantage here is that often you can tell from the binary data what the correct datatype is (e.g. BAM files assigned as fastqsanger.gz will start with "BAM"). We could also raise a message exception that just says "this isn't text data, check your datatype" ... I don't know what's better, but this is easier.

Fixes
https://sentry.galaxyproject.org/share/issue/a8843884527f4e4089b32fd14a2f126d/:

UnicodeDecodeError: 'utf-8' codec can't decode byte 0xff in position 4: invalid start byte
  File "galaxy/web/framework/middleware/error.py", line 167, in __call__
    app_iter = self.application(environ, sr_checker)
  File "galaxy/web/framework/middleware/statsd.py", line 29, in __call__
    req = self.application(environ, start_response)
  File "/cvmfs/main.galaxyproject.org/venv/lib/python3.11/site-packages/paste/httpexceptions.py", line 635, in __call__
    return self.application(environ, start_response)
  File "galaxy/web/framework/base.py", line 174, in __call__
    return self.handle_request(request_id, path_info, environ, start_response)
  File "galaxy/web/framework/base.py", line 263, in handle_request
    body = method(trans, **kwargs)
  File "galaxy/webapps/galaxy/controllers/dataset.py", line 152, in display
    display_data, headers = data.datatype.display_data(
  File "galaxy/datatypes/sequence.py", line 785, in display_data
    "/dataset/large_file.mako", truncated_data=fh.read(max_peek_size), data=dataset
  File "<frozen codecs>", line 322, in decode

Which is a BAM file assigned to fastqsanger.gz

(Please replace this header with a description of your pull request. Please include BOTH what you did and why you made the changes. The "why" may simply be citing a relevant Galaxy issue.)
(If fixing a bug, please add any relevant error or traceback)
(For UI components, it is recommended to include screenshots or screencasts)

How to test the changes?

(Select all options that apply)

• I've included appropriate automated tests.
• This is a refactoring of components with existing test coverage.
• Instructions for manual testing are as follows:
  1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

• I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

[wm75]

Reading single chars until you hit a newline was never ideal, but with a binary file this could potentially take a really long time, couldn't it?

[mvdbeek]

arg, yes, we're not reading from from the chunk ...

[wm75]

Would it perhaps be better to catch the error and handle it via a common text datatype fallback?

[mvdbeek]

via a common text datatype fallback?

I'm not sure what you mean by that ? Yes, probably better to raise an exception

[wm75]

I meant catching the exception, then re-opening as binary file and providing a generic chunk of data as preview.
Raising the exception is also fine though.