Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor config documentation enhancements #18499

Merged
merged 4 commits into from
Jul 11, 2024

Conversation

bgruening
Copy link
Member

(Please replace this header with a description of your pull request. Please include BOTH what you did and why you made the changes. The "why" may simply be citing a relevant Galaxy issue.)
(If fixing a bug, please add any relevant error or traceback)
(For UI components, it is recommended to include screenshots or screencasts)

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@martenson martenson self-assigned this Jul 5, 2024
@martenson
Copy link
Member

martenson commented Jul 5, 2024

the last commit here (7264a82) remove the user_config_templates_index_by option from the generated documents. It has already been missing from the schema, so I assume only the regeneration was behind. However it is still explicitly used in this test: https://github.com/galaxyproject/galaxy/blob/dev/test/unit/app/managers/test_user_file_sources.py#L591

Most likely a dead code line?

@martenson martenson added this to the 24.2 milestone Jul 5, 2024
@mvdbeek mvdbeek merged commit a7fb571 into galaxyproject:dev Jul 11, 2024
49 of 50 checks passed
@bgruening bgruening deleted the obs_cache_size branch July 11, 2024 09:41
@ahmedhamidawan ahmedhamidawan changed the title small docs enhancement Minor config documentation enhancements Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants