Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.0] Add input extra files to get_input_fnames #18462

Merged

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Jun 28, 2024

This should fix volume mounts in kubernetes,
which calls:

volume_mounts.extend(generate_relative_mounts(data_claim, job_wrapper.job_io.get_input_fnames()))

The only other consumers are pbs, using an undocument config option (ahem ...).

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

This should fix volume mounts in kubernetes,
which calls:

```
volume_mounts.extend(generate_relative_mounts(data_claim, job_wrapper.job_io.get_input_fnames()))
```
The only other consumers are pbs, using an undocument config option
(ahem ...).
@ksuderman
Copy link
Contributor

Thanks Marius. I've tested this and it solves the problem we were looking at in Brno.

@mvdbeek mvdbeek requested a review from a team June 29, 2024 10:01
@mvdbeek
Copy link
Member Author

mvdbeek commented Jun 29, 2024

Awesome, thanks for checking!

@mvdbeek mvdbeek merged commit 368eeaa into galaxyproject:release_24.0 Jun 29, 2024
46 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants