[24.0] Fix dropped when_expression on step upgrade #18446

mvdbeek · 2024-06-27T13:16:11Z

How to test the changes?

(Select all options that apply)

I've included appropriate automated tests.
This is a refactoring of components with existing test coverage.
Instructions for manual testing are as follows:
1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

mvdbeek added kind/bug area/workflows labels Jun 27, 2024

mvdbeek changed the title ~~Fix dropped when_expression on step upgrade~~ [24.0] Fix dropped when_expression on step upgrade Jun 27, 2024

mvdbeek changed the base branch from dev to release_24.0 June 27, 2024 13:31

mvdbeek added 2 commits June 27, 2024 15:31

Add test to make sure when_expression is not lost on refactoring

5050ccd

Fix dropped when_expression on workflow/tool_upgrade

ed8dc4b

Fixes galaxyproject#18441

mvdbeek force-pushed the when_upgrade_fix branch from 69ffd24 to ed8dc4b Compare June 27, 2024 13:31

mvdbeek requested a review from a team June 28, 2024 07:25

jdavcs approved these changes Jun 28, 2024

View reviewed changes

mvdbeek merged commit 444ae58 into galaxyproject:release_24.0 Jul 1, 2024
43 of 50 checks passed