-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pod5 datatype #18419
Add pod5 datatype #18419
Conversation
lib/galaxy/datatypes/test/test.pod5
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make this file smaller ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I subset it to one read and it's still 19K.
@bernt-matthias @mvdbeek thanks for the reviews, I've made those changes. |
I can’t tell for sure if the test failures are related to my changes. Please let me know if I need to fix something in this PR. |
All test failures are unrelated to your PR, thanks! |
@TomHarrop you can backport datatypes to the stable release, eg. 24.1 |
Thanks @bgruening I tried to cherry-pick the commits into the release_24.1 branch here. |
I'd like to add the Oxford Nanopore binary Pod5 datatype to support the dorado wrapper I'm developing over here.
That PR also includes tool that can convert
fast5.tar
(already supported by Galaxy) topod5
.pod5 has a fixed signature so the sniffer just checks for that.
Thanks!
How to test the changes?
(Select all options that apply)
License