Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow OAuth 2.0 user defined file sources (w/Dropbox integration) #18272

Merged
merged 11 commits into from
Oct 15, 2024
Merged

Allow OAuth 2.0 user defined file sources (w/Dropbox integration) #18272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
01c42c8
Expand pre-checking of file source/object store configuration.
jmchilton Sep 26, 2024
edc5bc2
Allow oauth2 file sources with Dropbox initial implementation.
jmchilton Sep 26, 2024
1736eb1
Rework user file/object store for changes to client fetch arch.
jmchilton Sep 26, 2024
83656bf
🛠️: refactor FontAwesome icon import in `ConfigurationTestItem`
itisAliRH Oct 7, 2024
329f91e
🛠️: refactor FontAwesome icon import in `ConfigTemplate/InstanceDropD…
itisAliRH Oct 7, 2024
fd92a05
🎨: add template name to the title in `CreateForm`
itisAliRH Oct 7, 2024
e6eaa3b
🎨: add template name to the title in `EditInstance`
itisAliRH Oct 7, 2024
7d2229d
🎨: improve the loading alert and show error when there is an error wh…
itisAliRH Oct 7, 2024
7df9f7c
🛠️: refactor OAuth2 callback to handle errors and missing credentials…
itisAliRH Oct 7, 2024
c905259
Ensure error codes are valid in OAuth2 callback
davelopez Oct 8, 2024
946bded
Use UUID instead of ID in user object store test
davelopez Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions client/src/api/configTemplates.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,11 @@ export type SecretData = CreateInstancePayload["secrets"];
export type PluginAspectStatus = components["schemas"]["PluginAspectStatus"];
export type PluginStatus = components["schemas"]["PluginStatus"];

export type UpgradeInstancePayload = components["schemas"]["UpgradeInstancePayload"];
export type TestUpgradeInstancePayload = components["schemas"]["TestUpgradeInstancePayload"];
export type UpdateInstancePayload = components["schemas"]["UpdateInstancePayload"];
export type TestUpdateInstancePayload = components["schemas"]["TestUpdateInstancePayload"];

export interface TemplateSummary {
description: string | null;
hidden?: boolean;
Expand Down
4 changes: 2 additions & 2 deletions client/src/api/objectStores.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ export async function getObjectStoreDetails(id: string) {
if (id.startsWith("user_objects://")) {
const userObjectStoreId = id.substring("user_objects://".length);

const { data, error } = await GalaxyApi().GET("/api/object_store_instances/{user_object_store_id}", {
params: { path: { user_object_store_id: userObjectStoreId } },
const { data, error } = await GalaxyApi().GET("/api/object_store_instances/{uuid}", {
params: { path: { uuid: userObjectStoreId } },
});

if (error) {
Expand Down
Loading
Loading