Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt DRMAA job runner to push env vars to jobs #18269

Closed
wants to merge 1 commit into from

Conversation

meso-uca
Copy link

What : adapt DRMAA job runner to push environment variables to jobs. Change sample config files accordingly.
Why : on our galaxy instance which submits jobs onto an hpc slurm cluster, when the jobs need to get data from internet, it needs an http proxy to be set via environment variables. As slurm munge does not load variables defined in the user profile, and as galaxy uses libdrmaa to submit the jobs which accepts in the job template a parameter listing the env vars to add, the fix was quite obvious.

  • Instructions for manual testing are as follows:
    1. Adapt your config file following the example from job_conf.xml.sample_advanced to add environment variables
    2. Use galaxy to submit a job on the cluster ; the job should dump its environment.
    3. Check in the job output that the additional environment variables are present.

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@bernt-matthias
Copy link
Contributor

@meso-uca is the existing mechanism insufficient:

?

See also #16666 in case you use containers.

@meso-uca
Copy link
Author

Oh yes, you're absolutely right, the existing mechanism is enough. However, our production galaxy instance is currently running version 22.05, which does not offer this possibility. My bad, I should have checked next versions before submitting this pull request.
Is there any interest in merging this PR into the 22.05 version ? If not, just ignore this PR and we'll switch to the existing possibility when we upgrade our instance.

Thanks !

@mvdbeek
Copy link
Member

mvdbeek commented May 31, 2024

This has been possible for many years, so it should also work on 22.05.

@bernt-matthias
Copy link
Contributor

I'm going to close this. Check with the admin channel if you have trouble setting this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants