-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change InvocationsList
into a grid using GridList
#18088
Merged
dannon
merged 8 commits into
galaxyproject:dev
from
ahmedhamidawan:enhance_invocations_list
May 20, 2024
Merged
Change InvocationsList
into a grid using GridList
#18088
dannon
merged 8 commits into
galaxyproject:dev
from
ahmedhamidawan:enhance_invocations_list
May 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/ahmedhamidawan/galaxy/tree/invocations_panel In this ^ branch, I have added an Invocations Panel for the invocations activity: invocations_activity_panel_second.mp4Commit: 984341a |
4 tasks
ahmedhamidawan
force-pushed
the
enhance_invocations_list
branch
from
May 14, 2024 19:12
56ea5b5
to
d19c953
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Yep, they are solved on dev, you can rebase to get rid of them. |
This removes the `InvocationsList` component and instead uses the `GridList`. To make this possible, a few changes were made to the Grid components (such as more field types, non-filterable grid, expandable rows etc.). The invocations list now appears uniform with the other grids due to this change.
ahmedhamidawan
force-pushed
the
enhance_invocations_list
branch
from
May 17, 2024 22:18
d19c953
to
c9c824a
Compare
dannon
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
InvocationsList
component and instead uses theGridList
. To make this possible, a few changes were made to the Grid components (such as more field types, non-filterable grid, expandable rows etc.).The invocations list now appears uniform with the other grids due to this change:
One tricky thing here is that; to make expandable rows possible, I had to change the table in
GridList
from:to:
One alternative is that, we remove the expandable rows functionality (which allows you to see multiple invocations in one table) and instead rely on the invocations panel (screencast below; done in a separate PR) to quick-switch between invocations?
This also adds a
Import Invocation
button at the top right, which fixes part of #18047How to test the changes?
(Select all options that apply)
License