Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.0] Include exception info when something goes wrong while refreshing tokens #18008

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Apr 17, 2024

An error occurred when refreshing user token: (invalid_request) Missing Code

is the message we're currently logging, that's not enough to do anything with.

usegalaxy.eu has 3.9 million events like this in the last 30 days

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

```
An error occurred when refreshing user token: (invalid_request) Missing Code
```

is the message we're currently logging, that's not enough to do anything
with.
@mvdbeek mvdbeek added kind/bug area/admin area/auth Authentication and authorization labels Apr 17, 2024
@github-actions github-actions bot added this to the 24.1 milestone Apr 17, 2024
@mvdbeek mvdbeek merged commit 74bee10 into galaxyproject:release_24.0 Apr 17, 2024
49 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/admin area/auth Authentication and authorization kind/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants