Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop unused workflow controller methods #17974

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Drop unused workflow controller methods #17974

merged 1 commit into from
Apr 12, 2024

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Apr 12, 2024

Create and save_workflow_as usage was removed in #17406.
rename_async and annotate_async seem unused.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@mvdbeek mvdbeek added the kind/refactoring cleanup or refactoring of existing code, no functional changes label Apr 12, 2024
davelopez
davelopez approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@davelopez davelopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, still in draft?

@mvdbeek
Copy link
Member Author

mvdbeek commented Apr 12, 2024

Was just checking if the tests pass

@mvdbeek mvdbeek marked this pull request as ready for review April 12, 2024 13:50
@github-actions github-actions bot added this to the 24.1 milestone Apr 12, 2024
@dannon dannon merged commit 9ec7380 into galaxyproject:dev Apr 12, 2024
54 checks passed
@martenson martenson deleted the drop_unused_workflow_controller_code branch April 12, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davelopez davelopez davelopez approved these changes

Assignees
No one assigned
Labels
kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Milestone
24.1
Development

Successfully merging this pull request may close these issues.
3 participants
@mvdbeek @davelopez @dannon