Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[23.2] Don't call get_or_create_default_history() twice for invalidated sessions #17613

Merged
merged 1 commit into from
Mar 6, 2024
Merged

[23.2] Don't call get_or_create_default_history() twice for invalidated sessions #17613

merged 1 commit into from
Mar 6, 2024

Conversation

nsoranzo
Copy link
Member

@nsoranzo nsoranzo commented Mar 6, 2024

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@nsoranzo nsoranzo requested a review from mvdbeek March 6, 2024 02:04
@github-actions github-actions bot added this to the 23.2 milestone Mar 6, 2024
@nsoranzo
Copy link
Member Author

nsoranzo commented Mar 6, 2024

Test failures unrelated.

@mvdbeek mvdbeek merged commit 98c80e7 into galaxyproject:release_23.2 Mar 6, 2024
43 of 46 checks passed
@nsoranzo nsoranzo deleted the release_23.2_get_or_create_default_history_twice branch March 6, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvdbeek mvdbeek Awaiting requested review from mvdbeek

Assignees
No one assigned
Labels
kind/bug
Projects
None yet
Milestone
23.2
Development

Successfully merging this pull request may close these issues.
2 participants
@nsoranzo @mvdbeek