[23.2] Fix tool shed webapp #17597
Merged
[23.2] Fix tool shed webapp #17597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsoranzo
reviewed
Mar 5, 2024
lib/tool_shed/webapp/buildapp.py
Outdated
| @@ -36,6 +36,10 @@ class ToolShedGalaxyWebTransaction(GalaxyWebTransaction): | |||
| def repositories_hostname(self) -> str: | |||
| return url_for("/", qualified=True).rstrip("/") | |||
|
|
|||
| def get_or_create_default_history(self): | |||
| # tool shed has no concept of histories | |||
| return None | |||
There was a problem hiding this comment.
This may complicate type annotation when we add it. What about guarding the change in #17557 with a if self.webapp.name == "galaxy": instead?
There was a problem hiding this comment.
I assume the type checking would fail anyway on attempting to create the history, so this is maybe a bit easier ?
There was a problem hiding this comment.
You can raise NotImplementedError, I suppose?
mvdbeek
force-pushed
the
fix_tool_shed_tests
branch
from
c7b80fb to
feb38af
Compare
mvdbeek
commented
Mar 5, 2024
nsoranzo
approved these changes
Mar 5, 2024
dannon
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just make
get_or_create_default_historya no-op.How to test the changes?
(Select all options that apply)
License