Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendorize fastapi-utls.cbv #17205

Merged
merged 5 commits into from
Dec 22, 2023
Merged

Vendorize fastapi-utls.cbv #17205

merged 5 commits into from
Dec 22, 2023

Conversation

jdavcs
Copy link
Member

@jdavcs jdavcs commented Dec 18, 2023

Ref #17185
Supersedes #17202

This copies the one part of fastapi-utils that we use.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 23.2 milestone Dec 18, 2023
@jdavcs jdavcs added kind/refactoring cleanup or refactoring of existing code, no functional changes and removed area/testing area/packaging labels Dec 18, 2023
@jdavcs jdavcs modified the milestones: 23.2, 24.0 Dec 18, 2023
@jdavcs jdavcs mentioned this pull request Dec 19, 2023
4 tasks
@jmchilton
Copy link
Member

Beautiful. I really appreciate you doing this @jdavcs - it means a lot to me.

@jmchilton jmchilton merged commit 4bb1c4b into galaxyproject:dev Dec 22, 2023
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/API area/dependencies kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants