Migrate dataset extra files store to Pinia #17145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davelopez
added
area/UI-UX
kind/refactoring
- Deprecate the endpoint requiring a `history_id` as it is not necessary
- Use new Pinia store - Convert to typescript - Simplify code
davelopez
force-pushed
the
migrate_dataset_ext_files_store_pinia
branch
from
ef8becf to
e41447b
Compare
jmchilton
reviewed
Dec 8, 2023
davelopez
force-pushed
the
migrate_dataset_ext_files_store_pinia
branch
from
a4e7394 to
31809d5
Compare
|
Thank you @jmchilton! I removed the deprecation flag, you are right there is no need to deprecate it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #17119
Replaces the old Vuex store with a Pinia store and converts related files to Typescript.
How to test the changes?
License