Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.0] Assert that tus uploader instance has URL #17133

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Dec 6, 2023

Newer tusclient package allows passing in client in which case url can be None.

Fixes package tests.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Newer tusclient package allows passing in client in which case url can
be None.
@mvdbeek mvdbeek changed the base branch from dev to release_23.0 December 6, 2023 10:28
@mvdbeek mvdbeek merged commit f9be1a4 into galaxyproject:release_23.0 Dec 6, 2023
50 of 51 checks passed
@nsoranzo nsoranzo deleted the tusuploader_fix branch December 6, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants