Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vueify Admin Roles Grid #17118

Merged
merged 14 commits into from
Dec 6, 2023
Merged

Vueify Admin Roles Grid #17118

merged 14 commits into from
Dec 6, 2023

Conversation

guerler
Copy link
Contributor

@guerler guerler commented Dec 1, 2023 •
edited
Loading

Requires #17030. This PR replaces the legacy roles grid in the admin panel with a GridList module. Operation handlers from the admin controller have been moved to the roles manager and api.

image

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@guerler guerler added kind/enhancement area/UI-UX kind/refactoring cleanup or refactoring of existing code, no functional changes labels Dec 1, 2023
@guerler guerler force-pushed the grids_roles_admin branch 2 times, most recently from 5505931 to 523c9be Compare December 2, 2023 15:59
@guerler guerler marked this pull request as ready for review December 2, 2023 16:06
@github-actions github-actions bot added this to the 23.2 milestone Dec 2, 2023
@guerler guerler mentioned this pull request Dec 2, 2023
Merged
4 tasks
guerler added 14 commits December 5, 2023 08:15
@guerler guerler requested a review from davelopez December 5, 2023 16:11
@mvdbeek mvdbeek merged commit f129d90 into galaxyproject:dev Dec 6, 2023
51 checks passed
@mvdbeek
Copy link
Member

mvdbeek commented Dec 6, 2023

Thanks @guerler!

@guerler guerler deleted the grids_roles_admin branch December 6, 2023 13:26
@mvdbeek mvdbeek modified the milestones: 23.2, 24.0 Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davelopez davelopez davelopez approved these changes

Assignees
No one assigned
Labels
area/UI-UX kind/enhancement kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Milestone
24.0
Development

Successfully merging this pull request may close these issues.
3 participants
@guerler @mvdbeek @davelopez