Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.2] Disable admin notifications management if notifications are disabled in config #17114

Conversation

davelopez
Copy link
Contributor

Fixes #17108

When the notification system is disabled in the configuration you now get the following message:

Screenshot from 2023-11-30 15-33-29

How to test the changes?

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 23.2 milestone Nov 30, 2023
@martenson martenson merged commit f67b17a into galaxyproject:release_23.2 Nov 30, 2023
24 checks passed
@martenson
Copy link
Member

thanks @davelopez!

@davelopez davelopez deleted the 23.2_disable_notification_management_if_config_disabled branch December 1, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants