-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[23.2] Tool panel views overflow bug #17112
[23.2] Tool panel views overflow bug #17112
Conversation
If we have a long list of tool panel views, the views at the bottom are hidden and unreachable. Added an `overflow: auto` property to deal with this.
Cool! Any chance that you can display the "currently loading panel view name" instead of displaying the old panel name with the loading indicator and then changing it to the selected one? I guess it will feel nicer :) |
Used a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Should this fix be applied to 23.1 too?
The only problem with that could be that the Tool Panel overhaul (concerning the front end changes here) with the addition of |
Then 23.2 sounds good, that's why I was asking :D |
nice, thanks @ahmedhamidawan ! |
If we have a long list of tool panel views (like on Test right now), the views at the bottom are hidden and unreachable. Added an
overflow: auto
property to deal with this.Also added indicators that a panel view is currently loading, which was previously missing.
Screen.Recording.2023-11-30.at.7.11.52.PM.mov
Screen.Recording.2023-11-30.at.8.16.48.PM.mov
How to test the changes?
(Select all options that apply)
License