Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.2] Tool panel views overflow bug #17112

Conversation

ahmedhamidawan
Copy link
Member

@ahmedhamidawan ahmedhamidawan commented Nov 30, 2023

If we have a long list of tool panel views (like on Test right now), the views at the bottom are hidden and unreachable. Added an overflow: auto property to deal with this.

Also added indicators that a panel view is currently loading, which was previously missing.

Before 😠 After 😃
Screen.Recording.2023-11-30.at.7.11.52.PM.mov
Screen.Recording.2023-11-30.at.8.16.48.PM.mov

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

If we have a long list of tool panel views, the views at the
bottom are hidden and unreachable. Added an `overflow: auto`
property to deal with this.
@davelopez
Copy link
Contributor

Also added indicators that a panel view is currently loading, which was previously missing.

Cool! Any chance that you can display the "currently loading panel view name" instead of displaying the old panel name with the loading indicator and then changing it to the selected one? I guess it will feel nicer :)

@ahmedhamidawan
Copy link
Member Author

Cool! Any chance that you can display the "currently loading panel view name" instead of displaying the old panel name with the loading indicator and then changing it to the selected one? I guess it will feel nicer :)

Used a LoadingSpan to show which view will be loaded...
Updated the screencast above as well

Copy link
Contributor

@davelopez davelopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Should this fix be applied to 23.1 too?

@ahmedhamidawan
Copy link
Member Author

Looks good. Should this fix be applied to 23.1 too?

The only problem with that could be that the Tool Panel overhaul (concerning the front end changes here) with the addition of ToolPanel.vue and PanelViewMenu.vue was done for 23.2 and would be a major conflict when backporting?

@davelopez
Copy link
Contributor

Then 23.2 sounds good, that's why I was asking :D

@martenson martenson merged commit f1ade12 into galaxyproject:release_23.2 Nov 30, 2023
20 of 24 checks passed
@martenson
Copy link
Member

nice, thanks @ahmedhamidawan !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants