Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.1] Skip state filtering in __MERGE_COLLECTION__ tool #16937

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Oct 27, 2023

Fixes inputs getting skipped that are NEW, QUEUED, etc.

If you're after filtering out errored you should use the
__FILTER_FAILED_DATASETS__ tool.

Includes bonus test regression test for #16931 that I didn't get to yesterday.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Fixes inputs getting skipped that are NEW, QUEUED, etc.

If you're after filtering out errored you should use the
`__FILTER_FAILED_DATASETS__` tool.
@mvdbeek mvdbeek merged commit d93095a into galaxyproject:release_23.1 Oct 27, 2023
37 of 39 checks passed
@martenson martenson deleted the fix_merge_collection_input_state_handling branch October 27, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants