Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.1] Fix tag ownership check #16877

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Oct 18, 2023

I think that in the tool evaluation context we don't actually need the
cached_id performance tweak: we batch flushes now on map over creation
... which in fact breaks the assumption that we're setting the user id
here.

Fixes https://sentry.galaxyproject.org/share/issue/5b44d1ec20094a2ebe8331b1ef6e58a8/

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

... from database operation tool.
I think that in the tool evaluation context we don't actually need the
cached_id performance tweak: we batch flushes now on map over creation
... which in fact breaks the assumption that we're setting the user id
here.
@mvdbeek
Copy link
Member Author

mvdbeek commented Oct 18, 2023

Failing tests are unrelated

@mvdbeek mvdbeek requested a review from a team October 18, 2023 15:20
@mvdbeek mvdbeek merged commit cdbbbbe into galaxyproject:release_23.1 Oct 18, 2023
41 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants