Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Interactive Tool Ilastik #16837

Merged
merged 10 commits into from
Nov 15, 2024
Merged

Add Interactive Tool Ilastik #16837

merged 10 commits into from
Nov 15, 2024

Conversation

lldelisle
Copy link
Contributor

I added no test as it is an interactive tool but tell me if it is possible to do so. (I just tested locally)
I can make a gif but no time now.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 23.2 milestone Oct 12, 2023

## Link input images to current working directory
#for input in $infiles:
ln -s '$input' ./'$input.name' &&
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the history name of two dataset is the same this will crash. Maybe we can detect this, and prefix in this case?
We should also use '$input.element_identifier'

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does Ilastik itself tolerate 2 input files with the same name during import or some other step? If so, maybe we should error out the job if names are not unique?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @bgruening . Thanks. Ilastik does not see the $infiles before the user add them to the project so having identical names is not an issue (for example, it is possible to have identical names in different directories I think).

Copy link
Contributor Author

@lldelisle lldelisle Oct 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this interactive tool also allows to modify an existing project I would go for a tool failure when identifiers are identical. But I will make a better error handling.

@mvdbeek mvdbeek modified the milestones: 23.2, 24.0 Dec 19, 2023
@mvdbeek mvdbeek modified the milestones: 24.0, 24.1 Mar 5, 2024
@mvdbeek mvdbeek self-requested a review May 14, 2024 14:15
@jdavcs jdavcs modified the milestones: 24.1, 24.2 May 20, 2024
@mvdbeek mvdbeek merged commit 9960c31 into galaxyproject:dev Nov 15, 2024
36 of 38 checks passed
@mvdbeek
Copy link
Member

mvdbeek commented Nov 15, 2024

Thank you @lldelisle!

Copy link

This PR was merged without a "kind/" label, please correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants