-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Interactive Tool Ilastik #16837
Add Interactive Tool Ilastik #16837
Conversation
|
||
## Link input images to current working directory | ||
#for input in $infiles: | ||
ln -s '$input' ./'$input.name' && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the history name of two dataset is the same this will crash. Maybe we can detect this, and prefix in this case?
We should also use '$input.element_identifier'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does Ilastik itself tolerate 2 input files with the same name during import or some other step? If so, maybe we should error out the job if names are not unique?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch @bgruening . Thanks. Ilastik does not see the $infiles before the user add them to the project so having identical names is not an issue (for example, it is possible to have identical names in different directories I think).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this interactive tool also allows to modify an existing project I would go for a tool failure when identifiers are identical. But I will make a better error handling.
Thank you @lldelisle! |
This PR was merged without a "kind/" label, please correct. |
I added no test as it is an interactive tool but tell me if it is possible to do so. (I just tested locally)
I can make a gif but no time now.
How to test the changes?
(Select all options that apply)
License