Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust tz inclusion in workflow reports #16835

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

dannon
Copy link
Member

@dannon dannon commented Oct 11, 2023

Followup and minor fix/tweak to #16757 -- we pass this time string forward to child components, which can also include it in the document, which without this change will not correctly include the timezone. Now we do all the time string handling in one spot.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@dannon dannon marked this pull request as ready for review October 11, 2023 20:43
@github-actions github-actions bot added this to the 23.2 milestone Oct 11, 2023
@dannon dannon added kind/bug area/UI-UX kind/refactoring cleanup or refactoring of existing code, no functional changes labels Oct 11, 2023
…applies the timezone to child components which display (but do not re-process) this value.
@dannon dannon force-pushed the minor-tz-followup branch from f804ba0 to 8e624cb Compare October 11, 2023 20:50
@mvdbeek mvdbeek merged commit 862dc99 into galaxyproject:dev Oct 12, 2023
18 checks passed
@mvdbeek
Copy link
Member

mvdbeek commented Oct 12, 2023

Thank you @dannon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/UI-UX kind/bug kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
Development

Successfully merging this pull request may close these issues.

2 participants