Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use vue modal instead of global backbone modal in user preferences #16830

Merged
merged 3 commits into from
Oct 20, 2023
Merged

Use vue modal instead of global backbone modal in user preferences #16830

merged 3 commits into from
Oct 20, 2023

Conversation

guerler
Copy link
Contributor

@guerler guerler commented Oct 11, 2023 •
edited
Loading

This PR switches the modal used in the user preferences from backbone to Vue.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@guerler guerler added area/UI-UX kind/refactoring cleanup or refactoring of existing code, no functional changes labels Oct 11, 2023
@guerler guerler added this to the 23.2 milestone Oct 11, 2023
@guerler guerler marked this pull request as ready for review October 13, 2023 09:45
davelopez
davelopez approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@davelopez davelopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks!

@dannon dannon merged commit 4e13b2d into galaxyproject:dev Oct 20, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davelopez davelopez davelopez approved these changes

@itisAliRH itisAliRH itisAliRH approved these changes

Assignees
No one assigned
Labels
area/UI-UX kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Milestone
23.2
Development

Successfully merging this pull request may close these issues.
4 participants
@guerler @itisAliRH @davelopez @dannon