Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug (missing commit) + SA2.0 usage in model.Job.update_hdca_update_time_for_job #16777

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

jdavcs
Copy link
Member

@jdavcs jdavcs commented Oct 2, 2023

This was missing a commit statement: with autocommit=False if skip_locked is supported sa_session.execute(implicit_statement) will be rolled back. (unless it's committed later, which we shouldn't rely upon).

In fact, i wonder whether we shouldn't just use a connection here instead of the session (we are in the else clause). but, in any case, the commit was missing.

(pulled out of #16724 for convenience)
Ref #12541

UPDATE: nope, this doesn't work. Maybe try a connection instead...

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@jdavcs jdavcs added kind/bug area/database Galaxy's database or data access layer labels Oct 2, 2023
@jdavcs jdavcs added this to the 23.2 milestone Oct 2, 2023
@jdavcs jdavcs requested a review from mvdbeek October 2, 2023 21:53
@jdavcs jdavcs marked this pull request as draft October 2, 2023 21:59
@jdavcs jdavcs removed the request for review from mvdbeek October 2, 2023 21:59
@mvdbeek mvdbeek modified the milestones: 23.2, 24.0 Dec 19, 2023
@jdavcs jdavcs changed the base branch from dev to release_24.0 April 1, 2024 16:17
@jdavcs jdavcs changed the base branch from release_24.0 to dev April 1, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/database Galaxy's database or data access layer kind/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants