[23.1] Copy the collection contents by default when copying a collection #16717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess this is a bit of a cautionary tale about backwards compatibility vs reasonable defaults. |
nsoranzo
reviewed
Sep 21, 2023
mvdbeek
force-pushed
the
copy_elements
branch
from
9816c26 to
af4e639
Compare
nsoranzo
reviewed
Sep 21, 2023
mvdbeek
force-pushed
the
copy_elements
branch
2 times, most recently
from
edae72d to
b768439
Compare
That got left out when creating the new multi history view. Fixes galaxyproject#16716 and galaxyproject#16619.
... by copying the history instead of its contents. With the change of copying hdca contents by default we'd otherwise have find the right hids, which isn't really what this test is about.
mvdbeek
force-pushed
the
copy_elements
branch
from
50992cd to
73be5f3
Compare
dannon
approved these changes
Sep 25, 2023
nsoranzo
added a commit
to nsoranzo/galaxy
that referenced
this pull request
Sep 26, 2023
…inals`` Follow-up to galaxyproject#16717 . Minimal performance gain but helps document the parameter use after the change in default value to True.
4 tasks
nsoranzo
added a commit
to nsoranzo/bioblend
that referenced
this pull request
Sep 26, 2023
…lection()`` and BioBlend.objects ``History.create_dataset_collection()`` methods Fix tests broken by galaxyproject/galaxy#16717 .
nsoranzo
added a commit
to nsoranzo/galaxy
that referenced
this pull request
Sep 27, 2023
…inals`` Follow-up to galaxyproject#16717 . Minimal performance gain but helps document the parameter use after the change in default value to True.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That got left out when creating the new multi history view. Fixes #16716 and #16619.
How to test the changes?
(Select all options that apply)
License