Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update datatypes_conf.xml.sample with docx type #16713

Merged
merged 6 commits into from
Oct 25, 2023

Conversation

yvanlebras
Copy link
Contributor

(Please replace this header with a description of your pull request. Please include BOTH what you did and why you made the changes. The "why" may simply be citing a relevant Galaxy issue.)
(If fixing a bug, please add any relevant error or traceback)
(For UI components, it is recommended to include screenshots or screencasts)

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@yvanlebras
Copy link
Contributor Author

and in ue upstream galaxy code usegalaxy-eu#192

@yvanlebras
Copy link
Contributor Author

New try

Copy link
Contributor

@bernt-matthias bernt-matthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering where this is needed. IMHO docx is a format that should be avoided.

lib/galaxy/config/sample/datatypes_conf.xml.sample Outdated Show resolved Hide resolved
lib/galaxy/datatypes/binary.py Outdated Show resolved Hide resolved
@yvanlebras
Copy link
Contributor Author

You right Matthias BUT users / reaserchers want to have a docx in our case (generation of a draft of data paper from a metadata file) so they can download it to edit it before submitting it....

@yvanlebras
Copy link
Contributor Author

Hi Mattias, Björn, do you think this can be merged ?

@mvdbeek mvdbeek merged commit c5ad97c into galaxyproject:dev Oct 25, 2023
37 of 39 checks passed
@galaxyproject galaxyproject deleted a comment from github-actions bot Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants