-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use fs.onedatarestfs for Onedata files source plugin implementation #16690
Use fs.onedatarestfs for Onedata files source plugin implementation #16690
Conversation
The fs.onedatarestfs depends on a simple REST-based client for the Onedata system. The fs.onedatafs that was in the codebase until now was not a viable option - it could not be easily installed using pip due to giant amount of dependent libraries, many of which in C/C++.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the package and making this PR. Should greatly ease the pain of setting things up.
Co-authored-by: Nuwan Goonasekera <[email protected]>
Can you please also change the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Thanks @lopiola! |
This PR was merged without a "kind/" label, please correct. |
The fs.onedatarestfs depends on a simple REST-based client for the Onedata system. The fs.onedatafs that was in the codebase until now was not a viable option - it could not be easily installed using pip due to the giant amount of dependent libraries, many of which were in C/C++.
How to test the changes?
(Select all options that apply)
I've included appropriate automated tests.
This is a refactoring of components with existing test coverage.
Instructions for manual testing are as follows:
fs.onedatarestfs
package to currently used requirements (can be found in conditional-requirements.txt).file_sources_conf.yml
file in the config dir, copy the part concerning onedata fromfile_sources_conf.yml.sample
.user_preferences_extra_conf.yml
file in the config dir, copy the part concerning onedata fromuser_preferences_extra_conf.yml.sample
.galaxy.yml
file in the config dir with the following contentThere are no automated tests, as I believe specific file source plugins are not automatically tested.
License