-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add parameter name to validation errors #15440
Conversation
The unit test (actually doc test) failures in |
Thanks for checking. Should be easy to fix. Do you think that these should be "proper" unit tests? I created those back in the days when I knew even less about testing than today :) |
It'd be probably better but I don't have strong feelings on that. |
d36696d
to
5c050ce
Compare
and add "Parameter" before parameter name
and fix them
af7e8b2
to
4ca03dc
Compare
Good to go from my side. |
Thanks, really appreciate moving the tests to proper unit tests. |
This could be useful for tool testing. So far it was unclear which parameter had the validation error.
Not sure if this is also user facing .. then the parameter name might not be helpful.
How to test the changes?
(Select all options that apply)
License