Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameter name to validation errors #15440

Merged
merged 6 commits into from
Oct 23, 2023

Conversation

bernt-matthias
Copy link
Contributor

This could be useful for tool testing. So far it was unclear which parameter had the validation error.

Not sure if this is also user facing .. then the parameter name might not be helpful.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 23.1 milestone Jan 29, 2023
@nsoranzo
Copy link
Member

The unit test (actually doc test) failures in lib/galaxy/tools/parameters/validation.py are relevant, the others should be fixed by #15441 .

@bernt-matthias
Copy link
Contributor Author

The unit test (actually doc test) failures in lib/galaxy/tools/parameters/validation.py are relevant, the others should be fixed by #15441 .

Thanks for checking. Should be easy to fix. Do you think that these should be "proper" unit tests? I created those back in the days when I knew even less about testing than today :)

@nsoranzo
Copy link
Member

It'd be probably better but I don't have strong feelings on that.

@mvdbeek mvdbeek modified the milestones: 23.1, 23.2 Jun 21, 2023
@bernt-matthias bernt-matthias force-pushed the name-validation branch 3 times, most recently from d36696d to 5c050ce Compare July 30, 2023 16:49
@bernt-matthias
Copy link
Contributor Author

Good to go from my side.

@mvdbeek mvdbeek changed the title add parameter name to validation errors Add parameter name to validation errors Oct 23, 2023
@mvdbeek
Copy link
Member

mvdbeek commented Oct 23, 2023

Thanks, really appreciate moving the tests to proper unit tests.

@mvdbeek mvdbeek merged commit 223a8aa into galaxyproject:dev Oct 23, 2023
46 of 50 checks passed
@bernt-matthias bernt-matthias deleted the name-validation branch October 23, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants