Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type updates from @mr-c - part 2 #12899

Merged
merged 14 commits into from
Nov 16, 2021
Merged

Type updates from @mr-c - part 2 #12899

merged 14 commits into from
Nov 16, 2021

Conversation

mr-c
Copy link
Contributor

@mr-c mr-c commented Nov 10, 2021 •
edited
Loading

Why: common-workflow-lab#137
What: Improved type hints

How to test the changes?

(Select all options that apply)

  • This is a refactoring of components with existing test coverage.

License

  • I agree to license these contributions under Galaxy's current license.
  • I agree to allow the Galaxy committers to license these and all my past contributions to the core galaxy codebase under the MIT license. If this condition is an issue, uncheck and just let us know why with an e-mail to [email protected].

@nsoranzo nsoranzo added this to the 22.01 milestone Nov 10, 2021
@mr-c mr-c marked this pull request as draft November 10, 2021 18:19
@mr-c
Copy link
Contributor Author

mr-c commented Nov 10, 2021 •
edited
Loading

To wait until after #12868

@mr-c mr-c marked this pull request as ready for review November 11, 2021 13:35
@nsoranzo nsoranzo requested a review from jmchilton November 11, 2021 16:33
mr-c
mr-c commented Nov 11, 2021
View reviewed changes
lib/galaxy/managers/collections_util.py Outdated Show resolved Hide resolved
lib/galaxy/managers/collections.py Outdated Show resolved Hide resolved
@mr-c mr-c force-pushed the type_updates2 branch 2 times, most recently from b93b3f3 to 2eaea1f Compare November 12, 2021 09:58
@mvdbeek mvdbeek force-pushed the type_updates2 branch 2 times, most recently from 4115415 to b5bf4bd Compare November 12, 2021 16:01
@jmchilton jmchilton merged commit 0d7b5fe into galaxyproject:dev Nov 16, 2021
@jmchilton
Copy link
Member

Amazing - thanks so much!

@mr-c mr-c deleted the type_updates2 branch November 16, 2021 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvdbeek mvdbeek mvdbeek left review comments

@nsoranzo nsoranzo nsoranzo left review comments

@jmchilton jmchilton Awaiting requested review from jmchilton

Assignees
No one assigned
Labels
area/datatypes area/testing area/tool-framework BioHackEU21 kind/enhancement
Projects
None yet
Milestone
22.01
Development

Successfully merging this pull request may close these issues.
4 participants
@mr-c @jmchilton @nsoranzo @mvdbeek